netudima commented on code in PR #4902:
URL: https://github.com/apache/cassandra/pull/4902#discussion_r3546621398
##########
test/distributed/org/apache/cassandra/distributed/test/QueriesTableTest.java:
##########
@@ -121,13 +121,13 @@ private static void assertReadsAndWritesVisible()
String task = row.get("task").toString();
boolean localReaderThread = threadId.contains("Read") ||
threadId.contains("SharedPool-Worker");
- readVisible |= localReaderThread && task.contains("SELECT");
+ readVisible |= localReaderThread && task.contains("SELECT") &&
!task.contains("QUERY");
Review Comment:
It looks like the change is classified by AI incorrectly. I did not make it
to try to detect immediate workers. I did this change to differentiate
coordinator and replica execution parts. There is no explicit way to do it,
previously the test logic relied on thread names but after disabling of dynamic
thread renaming + taking in account a possible immediate execution - the thread
name is a non-reliable way to distinguish coordinator vs replica parts, so I've
adjusted the check and used a difference between task names as an extra
criteria.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
