Copilot commented on code in PR #4916:
URL: https://github.com/apache/cassandra/pull/4916#discussion_r3528815349
##########
src/java/org/apache/cassandra/utils/JVMStabilityInspector.java:
##########
@@ -200,7 +200,7 @@ private static void forceHeapSpaceOomMaybe(OutOfMemoryError
oom)
{
if (FORCE_HEAP_OOM_IGNORE_SET.contains(oom.getMessage()))
return;
- logger.error("Force heap space OutOfMemoryError in the presence of",
oom);
+ logger.error("Off-heap OOM forcing heap space OutOfMemoryError after
OutOfMemoryError:", oom);
Review Comment:
The new log message is still a bit confusing/redundant: it repeats
"OutOfMemoryError" and the phrase "after OutOfMemoryError" can read as if the
heap-space OOM already happened, even though it’s about to be forced. Consider
wording that states an off-heap OutOfMemoryError was detected and that a
heap-space OOM is being forced, without the extra "after" clause.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
