Copilot commented on code in PR #4916:
URL: https://github.com/apache/cassandra/pull/4916#discussion_r3533430116
##########
src/java/org/apache/cassandra/utils/JVMStabilityInspector.java:
##########
@@ -200,7 +200,7 @@ private static void forceHeapSpaceOomMaybe(OutOfMemoryError
oom)
{
if (FORCE_HEAP_OOM_IGNORE_SET.contains(oom.getMessage()))
return;
- logger.error("Force heap space OutOfMemoryError in the presence of",
oom);
+ logger.error("Non-heap OutOfMemoryError detected, forcing a heap
OutOfMemoryError to trigger standard JVM OOM handling:", oom);
Review Comment:
This log message states a "Non-heap" OutOfMemoryError, but
`forceHeapSpaceOomMaybe()` is invoked for any `OutOfMemoryError` except two
message strings ("Java heap space" and "GC Overhead limit exceeded"). For other
heap-related OOM variants (or a null message), this wording can still mislead
operators about where the OOM originated.
Consider wording the log so it does not assert non-heap unless the code
actually detects that condition, e.g. describe it as a generic OOM and include
the message for context.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
