Copilot commented on code in PR #1299: URL: https://github.com/apache/cassandra-python-driver/pull/1299#discussion_r3582529856
########## cassandra/query.py: ########## @@ -46,7 +46,7 @@ See https://issues.apache.org/jira/browse/CASSANDRA-7304 for further details on semantics. -.. versionadded:: 2.6.0 +.. version added:: 2.6.0 Review Comment: The Sphinx/reST directive here is malformed: `.. versionadded::` is the recognized directive, but `.. version added::` will not be parsed correctly and can break doc builds. ########## cassandra/concurrent.py: ########## @@ -89,7 +91,7 @@ def _execute(self, idx, statement, params): callback=self._on_success, callback_args=args, errback=self._on_error, errback_args=args) except Exception as exc: - # If we're not failing fast and all executions are raising, there is a chance of recursing + # If we're not failing fast and all executions are raising, there is a chance of recurring Review Comment: This comment describes recursion depth (`max_error_recursion` / `_exec_depth`), but it was changed to say "recurring". That changes the meaning and makes the comment misleading; it should refer to "recursing" here. ########## cassandra/cqltypes.py: ########## @@ -1006,9 +1020,11 @@ def evict_udt_class(cls, keyspace, udt_name): @classmethod def apply_parameters(cls, subtypes, names): - keyspace = subtypes[0].cass_parameterized_type() # when parsed from cassandra type, the keyspace is created as an unrecognized cass type; This gets the name back + # when parsed from cassandra type, the keyspace is created as an unrecognized cass type; This resolves the back Review Comment: This inline comment is grammatically incorrect/unclear ("This resolves the back") and no longer explains what the code is doing. It should state that `cass_parameterized_type()` is used to recover the keyspace name when it was parsed as an unrecognized type. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
