bschoening commented on code in PR #1300:
URL:
https://github.com/apache/cassandra-python-driver/pull/1300#discussion_r3621667815
##########
cassandra/cqltypes.py:
##########
@@ -1006,9 +1020,11 @@ def evict_udt_class(cls, keyspace, udt_name):
@classmethod
def apply_parameters(cls, subtypes, names):
- keyspace = subtypes[0].cass_parameterized_type() # when parsed from
cassandra type, the keyspace is created as an unrecognized cass type; This gets
the name back
+ # when parsed from cassandra type, the keyspace is created as an
unrecognized cass type; This resolves the name
+ keyspace = subtypes[0].cass_parameterized_type()
udt_name = _name_from_hex_string(subtypes[1].cassname)
- field_names = tuple(_name_from_hex_string(encoded_name) for
encoded_name in names[2:]) # using tuple here to match what comes into
make_udt_class from other sources (for caching equality test)
+ # tuple used to match what comes into make_udt_class from other
sources (for caching equality test)
Review Comment:
agreed, although the function name should stay 'tuple'
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
