smiklosovic opened a new pull request, #4942:
URL: https://github.com/apache/cassandra/pull/4942
Cassandra resolves pluggable extensions by class name from configuration,
schema, and tooling inputs. These names were loaded with an initializing
Class.forName(name) and type-checked only afterward, so the named class ran its
static initializer before its type was confirmed. After this change such
classes will be loaded without initialization, verified against the expected
interface or base class, and initialized only through normal use after
validation.
A shared FBUtilities.classForNameWithoutInitialization helper and typed
instanceOrConstruct/construct overloads apply this to the configurable
extension points loaded by class name: the authentication, authorization,
role-management, network and internode-authenticator backends, the partitioner,
audit logger, configuration loader, seed provider, snitch, abstract types,
secondary and custom indexes, compaction strategy, compressor, replication
strategy, SASI analyzers, key and cache providers, query handler, storage and
stream hooks, tracing, the JMX authorization proxy, MBeans, the monotonic
clock, nodetool Sjk, triggers, the sstableloader and stress class options, and
diagnostic event classes (loaded without initialization and checked against
DiagnosticEvent, preserving the InvalidClassException contract and the existing
package restriction).
Regression tests confirm that an invalid-type load is rejected without
initializing the target class, and that valid implementations still resolve.
Hadoop client integration and hard-coded JDK and internal class probes are
left unchanged.
patch by Jeremiah Jordan; reviewed by <reviewer> for CASSANDRA-21525
Thanks for sending a pull request! Here are some tips if you're new here:
* Ensure you have added or run the [appropriate
tests](https://cassandra.apache.org/_/development/testing.html) for your PR.
* Be sure to keep the PR description updated to reflect all changes.
* Write your PR title to summarize what this PR proposes.
* If possible, provide a concise example to reproduce the issue for a
faster review.
* Read our [contributor
guidelines](https://cassandra.apache.org/_/development/index.html)
* If you're making a documentation change, see our [guide to documentation
contribution](https://cassandra.apache.org/_/development/documentation.html)
Commit messages should follow the following format:
```
<One sentence description, usually Jira title or CHANGES.txt summary>
<Optional lengthier description (context on patch)>
patch by <Authors>; reviewed by <Reviewers> for CASSANDRA-#####
Co-authored-by: Name1 <email1>
Co-authored-by: Name2 <email2>
```
The [Cassandra
Jira](https://issues.apache.org/jira/projects/CASSANDRA/issues/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
