smiklosovic commented on code in PR #4942:
URL: https://github.com/apache/cassandra/pull/4942#discussion_r3594677541
##########
test/unit/org/apache/cassandra/db/marshal/TypeParserTest.java:
##########
@@ -37,6 +41,23 @@ public static void initDD()
DatabaseDescriptor.daemonInitialization();
}
+ @Test
+ public void testRejectsNonAbstractTypeWithoutInitializing() throws
SyntaxException
+ {
+
ClassLoadingTestSupport.assertNotInitialized(ClassLoadingTestNonAssignable.class);
+ try
+ {
+ TypeParser.parse(ClassLoadingTestNonAssignable.class.getName());
Review Comment:
all test methods which use the flow of "execute-fail-catch" can be replaced
by more idiomatic `assertThatThrownBy`, it is already used in this patch but
its usage is not applied everywhere applicable. There is no reason to have this
kind of discrepancy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
