absurdfarce commented on code in PR #1302: URL: https://github.com/apache/cassandra-python-driver/pull/1302#discussion_r3617445809
########## pyproject.toml: ########## @@ -6,7 +6,7 @@ requires = ["setuptools", "Cython>=3.0", "tomli"] name = "cassandra-driver" description = "Apache Cassandra Python Driver" version = "3.30.1" -dependencies = ['geomet>=1.1', "Deprecated>=1.3.1"] +dependencies = ['geomet>=1.1'] Review Comment: Another drive-by fix. We only added _Deprecated_ to 3.30.1 to handle the deprecation of the event loops. Now that those have been removed in 4.0.0 there's no real reason to keep this dependency around. ########## tests/__init__.py: ########## @@ -16,8 +16,6 @@ import unittest import logging -import sys -import socket Review Comment: A drive-by fix; while working on this PR I noticed that these imports were no longer used. I _suspect_ this came about after removing the event loops for CASSPYTHON-13 but I haven't explicitly verified that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
