Copilot commented on code in PR #1302: URL: https://github.com/apache/cassandra-python-driver/pull/1302#discussion_r3617693355
########## docs/installation.rst: ########## @@ -3,10 +3,10 @@ Installation Supported Platforms ------------------- -Python 3.10 through 3.14 are supported. Both CPython (the standard Python -implementation) and `PyPy <http://pypy.org>`_ are supported and tested. +Python 3.10 through 3.14 are supported. Linux, OSX, and Windows are supported. -Linux, OSX, and Windows are supported. +As of Python driver 4.0.0 only CPython is supported. Prior versions also explicitly supported PyPy but we no longer +support this runtime. See `CASSPYTHON-14 <https://issues.apache.org/jira/browse/CASSPYTHON-14>`_ for additional information. Review Comment: The new wording hard-codes "As of Python driver 4.0.0" while the same document (and pyproject) still show the current driver version as 3.30.1. This is internally inconsistent and may mislead readers about when PyPy support was dropped. Consider stating the support policy without tying it to a specific future driver version. ########## tests/unit/test_policies.py: ########## @@ -141,26 +141,16 @@ def host_down(): # make the GIL switch after every instruction, maximizing # the chance of race conditions Review Comment: This comment still refers to making the GIL switch "after every instruction", but the code now uses sys.setswitchinterval(), which adjusts the desired thread switch interval (time-based), not per-instruction switching. Updating the comment will keep the intent clear for future maintainers. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
