bschoening commented on code in PR #1300:
URL:
https://github.com/apache/cassandra-python-driver/pull/1300#discussion_r3621704289
##########
cassandra/metadata.py:
##########
@@ -789,16 +788,16 @@ def export_as_string(self):
other_tables = [t for t in self.tables.values() if t not in
tables_with_vertex]
cql = "\n\n".join(
- [self.as_cql_query() + ';'] +
- self.user_type_strings() +
- [f.export_as_string() for f in self.functions.values()] +
- [a.export_as_string() for a in self.aggregates.values()] +
- [t.export_as_string() for t in tables_with_vertex + other_tables])
+ [self.as_cql_query() + ';']
+ + self.user_type_strings()
+ + [f.export_as_string() for f in self.functions.values()]
+ + [a.export_as_string() for a in self.aggregates.values()]
+ + [t.export_as_string() for t in tables_with_vertex +
other_tables])
if self._exc_info:
import traceback
ret = "/*\nWarning: Keyspace %s is incomplete because of an error
processing metadata.\n" % \
- (self.name)
+ self.name
Review Comment:
yes, f-strings would be a nice change for later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]