vtermanis commented on PR #1344: URL: https://github.com/apache/jena/pull/1344#issuecomment-1142423413
> There are no tests covering the assembler change nor the functionality change. I did look to see what there was, but like you say, the assembler part is not currently tested. For the assembler, I presume you mean something [like this](https://github.com/apache/jena/blob/main/jena-permissions/src/test/java/org/apache/jena/permissions/SecuredAssemblerTest.java)? Or would it be more appropriate to explicitly call the updated assembler's `createDataset` and inspect the output (e.g. dataset has no spatial index in its context)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
