LorenzBuehmann commented on PR #1344: URL: https://github.com/apache/jena/pull/1344#issuecomment-1153112661
Nitpicking: why would we call the method `prepareSpatialExtension` at all if the spatial index isn't enabled? All it would do is to check emptiness of the dataset (which has no benefit) and then return in the next ìf` clause -> no need to call the method > Is there a reason why the index can't be updated? The reason is the underlying datastructure of JTS, the [`STRtree`](https://locationtech.github.io/jts/javadoc/org/locationtech/jts/index/strtree/STRtree.html) to which items cannot be inserted once it has been built. We could allow for an update mode and switch to a quadtree (a bit slower, but allows for insert/remove operations). Moreover, we will have think careful about updating the "other" indexing structure of the geospatial layer as well, i.e. that literal, transformation and query rewrite part I think. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
