afs commented on PR #1918: URL: https://github.com/apache/jena/pull/1918#issuecomment-1605444529
I ran the Jena core test suite just "because". For the GraphMem2, graphs there are 16 errors and 13 failures. Most errors look to all be lack of iterator.remove and the failures are mostly value/term related. No surprises. There some test that explicitly test for GraphMemBase - SimpleGraphMaker has some reference counting of (create,use)/close pairing. GraphMaker should probably go or at least migrate to the ontology code where and not be used elsewhere. GraphMem2Roaring needed one tweek. In RoaringBitmapTripleIterator,ext there is a CME test. With that, there were 40 errors. When I removed it, 16 errors like the others. I also tried a graph wrappers to simulate term semantics on GraphMem and also one that simulated value semantics on GraphMem2Fast. Similar sort of errors and failures plus a few where test code was testing for GraphMem. All these are FYI/later. Looks pretty good. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
