afs commented on PR #1918:
URL: https://github.com/apache/jena/pull/1918#issuecomment-1605489790
The way forward:
I'll keep looking at the code as and when time permits - it looks good
already.
There is some code tidying up : the idea is to make the code free of
warnings for some
When checking the code for releases, the no warnings/some warnings boundary
is easy to see whereas a change in the number of warnings isn't so easy to
notice. We don't have proscribed set of settings - I think I have close to the
default in Eclipse. It does mean it isn't always the set of warnings that you
use.
* Rewriting to make `@SuppressWarnings("squid:S1121")` and `"squid:2184"`
unnecessary.
* A few missing `@Override`
* Javadoc e.g. `@return` with no text.
* Use of generics in Javadoc..
* `Assert.assertThat` is deprecated. The one line fix for this gets rid of
most of the warnings!
I've put in a code review - it doesn't matter if they are not all caught.
They are be addressed later.
Then merge. 🥳
Then #1920 (GraphMemFactory)
Then put in factory calls into GraphMemFactory.
To me, that's enough to be ready 4.9.0. More access and further integration
is a bonus but it's dependent on time available. I'd like to get 4.9.0 done and
not wait unnecessarily. The northern vacation season approaches and it's push
5.x later.
At this point, exploring the consequences of term-semantics is much easier
with GraphMem2* in the codebase. That'll include discovering long forgotten
code like GraphMaker and its tight coupling to GraphMem1 - knocking off issues
one by one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
