rvesse commented on code in PR #2152:
URL: https://github.com/apache/jena/pull/2152#discussion_r1442790001
##########
jena-extras/jena-querybuilder/src/main/java/org/apache/jena/arq/querybuilder/rewriters/BuildElementVisitor.java:
##########
@@ -125,8 +125,16 @@ public void visit(ElementGroup el) {
// noting to do
result = el;
} else if (lst.size() == 1) {
Review Comment:
It looks like a lot of the test suite assumes this simplification, removing
it generates 67 failures of the module so possibly your approach from #2155 of
allowing these forms to compile might be more broadly useful especially since
users could be building query ASTs in other ways
@afs Just discovered while working on $dayjob code that's using query
builder this morning that similar cases exists for other elements. E.g. create
a query with just a `BIND` also exhibits the same problem
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
