afs commented on code in PR #2152:
URL: https://github.com/apache/jena/pull/2152#discussion_r1442886998
##########
jena-extras/jena-querybuilder/src/main/java/org/apache/jena/arq/querybuilder/rewriters/BuildElementVisitor.java:
##########
@@ -125,8 +125,16 @@ public void visit(ElementGroup el) {
// noting to do
result = el;
} else if (lst.size() == 1) {
Review Comment:
Then better to solve in the `AlgebraGenerator`.
I'll add `ElementBind` to #2155 and look for a general solution.
A separate matter which would need test case changes is whether
querybuilder should create ASTs the parser might generate and have the
equivalance `querybuilder -> string -> parse-> query` and `querybuilder.build
-> query`.
When used over the wire, queries from the querybuilder are turned into
strings.
Issue #2156 for whether the querybuilder ought to try for parser-compatible
syntax structures.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
