Aklakan commented on PR #2253:
URL: https://github.com/apache/jena/pull/2253#issuecomment-1964343756

   * This is now an internal method 
`QueryExecHTTPBuilderOverRDFLinkHTTP.queryStringValidated` which sets a query 
string and validates it if if `parseCheckQueries` is enabled.
   * I changed `QueryExecHTTPBuilder.setQuery` from private to protected in 
order to be able to update the state of the builder consistently when a query 
object or string is set.
   
   A couple of notes for future reference:
   
   1. It turns out that so far there is no public API on `QueryExecHTTPBuilder` 
to set a query string and have at processed according to the RDFLinkHTTP config:
   
   * The `query(String)` method are all expected to parse the query string so 
that e.g. substitution can be performed
   * The `queryString(String)` method on `ExecHTTPBuilder` explicitly states 
that `The queryString is not interpreted and it may contain SPARQL syntax`.
   
   2. `QueryType` does not discriminate between construct triples and construct 
quads. If it did, then it would no longer be needed to pass the `parsedQuery` 
around. The constant `CONSTRUCT_QUADS` is commented out because apparently for 
other use cases it was not needed.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to