Aklakan commented on code in PR #2253:
URL: https://github.com/apache/jena/pull/2253#discussion_r1502727759
##########
jena-rdfconnection/src/main/java/org/apache/jena/rdflink/RDFLinkHTTP.java:
##########
@@ -241,77 +243,111 @@ public QueryExec query(Query query) {
@Override
public QueryExecBuilder newQuery() {
- return createQExecBuilder();
+ return createQExecBuilder(null);
}
// Create the QExec
private QueryExec queryExec(Query query, String queryString, QueryType
queryType) {
- checkQuery();
- if ( query == null && queryString == null )
- throw new InternalErrorException("Both query and query string are
null");
- if ( query == null ) {
- if ( parseCheckQueries )
- // Don't retain the query.
- QueryFactory.create(queryString);
Review Comment:
The query string validation is now eager upon setting the query string on
the builder.
RDFLinkHTTP now consistently delegates to the setter on the builder.
The test case has been added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
