Aklakan commented on PR #2405: URL: https://github.com/apache/jena/pull/2405#issuecomment-2225717549
I think the code is ready for review. I agree that there is no need to rush it for 5.1.0. I haven't looked into how to generate those charts from jmh - a copy&paste of the output of running the benchmark class `TestBenchmarkHashJoin` (after running `mvn install` on the `jena-benchmarks-jmh` module in order to generate the `BenchmarkList` file) gives the following output: ``` Benchmark (param0_jenaVersion) (param1_queryFile) Mode Cnt Score Error Units BenchmarkHashJoin.runTask current join/join_2columns_simple_a_10.ttl avgt 5 0.072 ± 0.036 s/op BenchmarkHashJoin.runTask current join/join_2columns_simple_a_15.ttl avgt 5 0.268 ± 0.086 s/op BenchmarkHashJoin.runTask current join/join_2columns_simple_a_20.ttl avgt 5 0.939 ± 0.695 s/op BenchmarkHashJoin.runTask current join/join_2columns_skewed_a_1.ttl avgt 5 0.003 ± 0.002 s/op BenchmarkHashJoin.runTask current join/join_2columns_skewed_a_10.ttl avgt 5 3.539 ± 0.421 s/op BenchmarkHashJoin.runTask current join/join_matrix_skewed_a_10.ttl avgt 5 0.002 ± 0.001 s/op BenchmarkHashJoin.runTask current join/join_1column_simple_a_10k.ttl avgt 5 0.041 ± 0.016 s/op BenchmarkHashJoin.runTask current join/join_1column_simple_a_100k.ttl avgt 5 0.489 ± 0.020 s/op BenchmarkHashJoin.runTask 4.8.0 join/join_2columns_simple_a_10.ttl avgt 5 0.179 ± 0.032 s/op BenchmarkHashJoin.runTask 4.8.0 join/join_2columns_simple_a_15.ttl avgt 5 1.028 ± 0.075 s/op BenchmarkHashJoin.runTask 4.8.0 join/join_2columns_simple_a_20.ttl avgt 5 6.097 ± 3.102 s/op BenchmarkHashJoin.runTask 4.8.0 join/join_2columns_skewed_a_1.ttl avgt 5 0.009 ± 0.008 s/op BenchmarkHashJoin.runTask 4.8.0 join/join_2columns_skewed_a_10.ttl avgt 5 (disabled because each run takes more than a minute) BenchmarkHashJoin.runTask 4.8.0 join/join_matrix_skewed_a_10.ttl avgt 5 0.002 ± 0.001 s/op BenchmarkHashJoin.runTask 4.8.0 join/join_1column_simple_a_10k.ttl avgt 5 0.045 ± 0.034 s/op BenchmarkHashJoin.runTask 4.8.0 join/join_1column_simple_a_100k.ttl avgt 5 0.476 ± 0.065 s/op ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: pr-unsubscr...@jena.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@jena.apache.org For additional commands, e-mail: pr-h...@jena.apache.org
