Aklakan commented on code in PR #2405: URL: https://github.com/apache/jena/pull/2405#discussion_r1713427924
########## jena-arq/src/main/java/org/apache/jena/sparql/engine/join/JoinKey.java: ########## @@ -17,96 +17,125 @@ */ package org.apache.jena.sparql.engine.join; -import java.util.*; +import java.util.ArrayList; +import java.util.Collection; +import java.util.List; import org.apache.jena.sparql.core.Var ; /** JoinKey for hash joins */ -public final class JoinKey implements Iterable<Var> +public final class JoinKey extends ImmutableUniqueList<Var> Review Comment: Unsure whether JoinKey should extend ImmutableUniqueList or include it as a field. ImmutableUniqueList provides an indexed List.indexOf() method - it could be seen as an internal class. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: pr-unsubscr...@jena.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@jena.apache.org For additional commands, e-mail: pr-h...@jena.apache.org
