afs commented on code in PR #2676:
URL: https://github.com/apache/jena/pull/2676#discussion_r1740130100
##########
jena-ontapi/src/main/java/org/apache/jena/ontapi/OntModelControls.java:
##########
@@ -247,19 +242,14 @@ public enum OntModelControls {
*/
USE_OWL_PROPERTY_IRREFLEXIVE_FEATURE,
/**
- * Controls {@link OWL2#inverseOf owl:inverseOf} functionality.
+ * Controls {@link OWL2#inverseOf owl:inverseOf} functionality
(InverseObjectProperty axiom).
* If disabled,
* {@link OntObjectProperty#inverseProperties()
OntObjectProperty#inverseProperties()}
- * will return {@code false}, modification operations, such as
+ * will return empty {@code Stream}, modification operations, such as
Review Comment:
```suggestion
* will return an empty {@code Stream}, modification operations, such as
```
##########
jena-ontapi/src/main/java/org/apache/jena/ontapi/OntModelControls.java:
##########
@@ -247,19 +242,14 @@ public enum OntModelControls {
*/
USE_OWL_PROPERTY_IRREFLEXIVE_FEATURE,
/**
- * Controls {@link OWL2#inverseOf owl:inverseOf} functionality.
+ * Controls {@link OWL2#inverseOf owl:inverseOf} functionality
(InverseObjectProperty axiom).
* If disabled,
* {@link OntObjectProperty#inverseProperties()
OntObjectProperty#inverseProperties()}
- * will return {@code false}, modification operations, such as
+ * will return empty {@code Stream}, modification operations, such as
* {@link OntObjectProperty#addInverseProperty(OntObjectProperty)
OntObjectProperty#addInverseProperty(OntObjectProperty)},
* will throw {@link OntJenaException.Unsupported
OntJenaException.Unsupported} exception.
*/
- USE_OWL_PROPERTY_INVERSE_OF_FEATURE,
- /**
- * If this key is set to {@code true}, an anonymous inverse object
property type is enabled (OWL2 feature).
- * That is {@code _:x owl:inverseOf PN}, where {@code _:x} is a b-node and
{@code PN} is a named object property.
- */
- USE_OWL_INVERSE_OBJECT_PROPERTY_FEATURE,
+ USE_OWL_INVERSE_OBJECT_PROPERTIES_FEATURE,
Review Comment:
I agree that "Properties" is a better name.
`jena-ontapi` is new and it is noted as experimental. Incompatible changes
are not unreasonable are this stage. It is used as a library so these changes
show up in the application. If the new version is a drop-in, then the app
breaks. If the app is rebuilt, a compiler time error occurs and it can be fixed.
To become more stable, the code will need to adopt deprecate-remove-later
and semantic versioning where possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
