afs commented on code in PR #2676:
URL: https://github.com/apache/jena/pull/2676#discussion_r1741062326
##########
jena-ontapi/src/main/java/org/apache/jena/ontapi/OntModelControls.java:
##########
@@ -247,19 +242,14 @@ public enum OntModelControls {
*/
USE_OWL_PROPERTY_IRREFLEXIVE_FEATURE,
/**
- * Controls {@link OWL2#inverseOf owl:inverseOf} functionality.
+ * Controls {@link OWL2#inverseOf owl:inverseOf} functionality
(InverseObjectProperty axiom).
* If disabled,
* {@link OntObjectProperty#inverseProperties()
OntObjectProperty#inverseProperties()}
- * will return {@code false}, modification operations, such as
+ * will return empty {@code Stream}, modification operations, such as
* {@link OntObjectProperty#addInverseProperty(OntObjectProperty)
OntObjectProperty#addInverseProperty(OntObjectProperty)},
* will throw {@link OntJenaException.Unsupported
OntJenaException.Unsupported} exception.
*/
- USE_OWL_PROPERTY_INVERSE_OF_FEATURE,
- /**
- * If this key is set to {@code true}, an anonymous inverse object
property type is enabled (OWL2 feature).
- * That is {@code _:x owl:inverseOf PN}, where {@code _:x} is a b-node and
{@code PN} is a named object property.
- */
- USE_OWL_INVERSE_OBJECT_PROPERTY_FEATURE,
+ USE_OWL_INVERSE_OBJECT_PROPERTIES_FEATURE,
Review Comment:
Using a `@Deprecated` marking usually means "it works for now but will not
at some point".
If the constant no longer has any effect, that is, there is a change in
behaviour, then it might as be removed.
There is only so much effort worth spending on leaving the old way in place.
This module is new and we did categorise it as experimental.
If it is effort and distorts the code, then just remove them.
BTW: `@Deprecated(forRemovel = true)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]