Aklakan commented on code in PR #2925:
URL: https://github.com/apache/jena/pull/2925#discussion_r1908608373
##########
jena-arq/src/main/java/org/apache/jena/sparql/algebra/table/TableData.java:
##########
@@ -18,23 +18,21 @@
package org.apache.jena.sparql.algebra.table ;
+import java.util.Collections;
import java.util.List ;
import org.apache.jena.sparql.ARQException ;
import org.apache.jena.sparql.core.Var ;
import org.apache.jena.sparql.engine.binding.Binding ;
+/** Immutable table. */
public class TableData extends TableN {
public TableData(List<Var> variables, List<Binding> rows) {
- super(variables, rows) ;
+ super(Collections.unmodifiableList(variables),
Collections.unmodifiableList(rows)) ;
Review Comment:
TableData appears to be intended as immutable but this was so far not
enforced - one could call getRows() and modify them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@jena.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@jena.apache.org
For additional commands, e-mail: pr-h...@jena.apache.org
