Aklakan commented on code in PR #2925:
URL: https://github.com/apache/jena/pull/2925#discussion_r1908602744
##########
jena-arq/src/main/java/org/apache/jena/query/Query.java:
##########
@@ -98,7 +98,7 @@ public class Query extends Prologue implements Cloneable,
Printable
public static final int ORDER_UNKNOW = -3 ;
// VALUES trailing clause
- protected TableData valuesDataBlock = null ;
+ protected TableN valuesDataBlock = null ;
Review Comment:
Should the valuesDataBlock be mutable or not? One test case written by me
some years ago assumed it to be mutable. The test case clones a query and
checks that modification of the clone's valuesDataBlock does not affect the
original one.
But the implementation of TableData suggests that it is intended to be
immutable anyway as the addBinding method is overridden to reject updates.
As I see it: TableN -> mutable, TableData -> immutable - much like guava's
List and ImmutableList.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@jena.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@jena.apache.org
For additional commands, e-mail: pr-h...@jena.apache.org
