kinow commented on code in PR #3010:
URL: https://github.com/apache/jena/pull/3010#discussion_r1956725745
##########
jena-fuseki2/jena-fuseki-ui/vite.config.js:
##########
@@ -48,8 +56,8 @@ export default defineConfig({
},
},
build: {
- // Our largest chunk: dist/assets/yasqe.min-ec8f4984.js 508.16 kB │ gzip:
130.97 kB
- chunkSizeWarningLimit: 550,
+ // Our largest chunk: target/webapp/static/Query-CakHSd_3.js 1,172.48 kB
│ gzip: 350.95 kB
+ chunkSizeWarningLimit: 1250,
Review Comment:
I haven't looked at the code in a while, but I remember the warnings from
s/css and chunk size, but I never had time to check each and see if we had a
fix or if we had to simply suppress.
Can't tell whether it's better to simply suppress or leave the warnings in
the build log. I'd leave them so I don't forget to fix it later, but if that is
an issue for others actively maintaining it then it's probably better to
suppress these.
Thanks!
##########
jena-fuseki2/jena-fuseki-ui/package.json:
##########
@@ -65,14 +68,14 @@
"nanoid": "^5.0.9",
"nodemon": "^3.0.1",
"run-script-os": "^1.1.6",
- "sass": "^1.69.4",
+ "sass-embedded": "^1.85.0",
Review Comment:
:+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@jena.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@jena.apache.org
For additional commands, e-mail: pr-h...@jena.apache.org
