OyvindLGjesdal commented on code in PR #3010:
URL: https://github.com/apache/jena/pull/3010#discussion_r1957401450
##########
jena-fuseki2/jena-fuseki-ui/vite.config.js:
##########
@@ -48,8 +56,8 @@ export default defineConfig({
},
},
build: {
- // Our largest chunk: dist/assets/yasqe.min-ec8f4984.js 508.16 kB │ gzip:
130.97 kB
- chunkSizeWarningLimit: 550,
+ // Our largest chunk: target/webapp/static/Query-CakHSd_3.js 1,172.48 kB
│ gzip: 350.95 kB
+ chunkSizeWarningLimit: 1250,
Review Comment:
Hi @kinow and thanks for the review
> I'd leave them so I don't forget to fix it later, but if that is an issue
for others actively maintaining it then it's probably better to suppress these.
I think there are two different issues:
* The chunk size warning I think is probably better to leave in the logs, so
it is kept visible.
* the scss (44/60 warnings in the build) warnings I *believe* are mostly
inherited from Bootstrap. There are some scss errors which are local to the
Jena Fuseki UI, but most of the warnings are for rules within node_modules
which are native to Bootstrap. Waiting (creating an issue?) for the Bootstrap
patch to complete and then (fixing the Jena warnings/attempting migration) also
make senses, but I silenced it due to it mostly being external and because of
the large number of warnings.
Attempting to use the helper for migration
(https://sass-lang.com/documentation/breaking-changes/import/) complains about
bootstrap, and exits before changing anything. (The docs doesn't mention how to
fix manually 🤔)
Hopefully this will be fixed upstream, so that the migration for the UI
works:
```
# after minor fixes to import paths in index.scss to relative, and adding a
css file extension:
sass-migrator --migrate-deps --load-path . --dry-run module --migrate-deps
src/styles/index.scss --dry-run
Error: The migrator wants to rename a member in
node_modules/bootstrap/scss/_functions.scss, but it is not being migrated. You
should re-run the migrator with --migrate-deps or with
node_modules/bootstrap/scss/_functions.scss as one of your entrypoints.
```
I'm ok with updating to either, I am unsure of if the warning silencings are
helpful or not, but got a bit caught in the moment and tried to get towards 0
warnings in the build 😎
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@jena.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@jena.apache.org
For additional commands, e-mail: pr-h...@jena.apache.org
