Aklakan commented on code in PR #3063:
URL: https://github.com/apache/jena/pull/3063#discussion_r1992005204
##########
jena-rdfconnection/src/main/java/org/apache/jena/rdflink/RDFLinkAdapter.java:
##########
@@ -89,10 +84,18 @@ public DatasetGraph getDataset() {
}
@Override
- public QueryExec query(Query query) { return
QueryExec.adapt(conn.query(query)); }
+ public QueryExec query(Query query) {
+ try (QueryExecution qExec = conn.query(query)) {
+ return QueryExec.adapt(qExec);
Review Comment:
IMHO this doesn't look right - this would return an adapter backed by a
closed QueryExecution object.
(same below)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@jena.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@jena.apache.org
For additional commands, e-mail: pr-h...@jena.apache.org
