afs commented on code in PR #3063:
URL: https://github.com/apache/jena/pull/3063#discussion_r1993283886
##########
jena-rdfconnection/src/main/java/org/apache/jena/rdflink/RDFLinkAdapter.java:
##########
@@ -89,10 +84,18 @@ public DatasetGraph getDataset() {
}
@Override
- public QueryExec query(Query query) { return
QueryExec.adapt(conn.query(query)); }
+ public QueryExec query(Query query) {
+ try (QueryExecution qExec = conn.query(query)) {
+ return QueryExec.adapt(qExec);
Review Comment:
> Removed. I think I don't have the background and skill for creating a fix
here, but hopefully I can help to debug.
Personally, I don't what the problem is! Fixing it would be easier
otherwise. 😞
1. It is only on github actions
1. It is almost always one of a few tests that fail e.g.
`TestFusekiShaclValidation.shacl_no_data_graph`
1. Very occasional a different test will fail.
1. One server per test seems more reliable than one server per test suite.
1. Java17 fails more often than java21.
1. Not stopping any servers and just leaving it lying around does not fix
the problem.
At the moment, I have a trial system where the problem tests are isolated in
their own test suite. I'm runnign it on my personal GH account so as not to
drown the ASF project. https://github.com/afs/jena/tree/tests-experiment
`TestFusekiShaclValidation.shacl_no_data_graph` will intermittently fail
when run in its own test suite with its own server setup. But the test is
single threaded and the server side operation does execute and does log
returning the expected 404. But the test does not receive the response ("0
bytes"). Even if the server is never closed!
(I'm likely to run out of GH free-use resources this accounting period.)
PS The UI steps can fail because of "yarn install" failure. This may be
because I'm using theGH mirror registry too much.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@jena.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@jena.apache.org
For additional commands, e-mail: pr-h...@jena.apache.org
