afs commented on code in PR #3027: URL: https://github.com/apache/jena/pull/3027#discussion_r2072398215
########## jena-geosparql/src/main/java/org/locationtech/jts/index/strtree/STRtreeSerializer.java: ########## @@ -0,0 +1,155 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.locationtech.jts.index.strtree; + +import java.util.ArrayList; +import java.util.List; + +import org.locationtech.jts.geom.Envelope; + +import com.esotericsoftware.kryo.Kryo; +import com.esotericsoftware.kryo.Serializer; +import com.esotericsoftware.kryo.io.Input; +import com.esotericsoftware.kryo.io.Output; + +/* This file is an adapted copy of org.locationtech.jts.index.strtree.IndexSerde. */ Review Comment: Could you put that it comes from Sedona in the comment please so that it is clear is not derived from JTS code? And a note about why it is in the package it is in would be good. Whether having classes in the same package spread across jars will continue working is anyone's guess, although shading crushes the distinction. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: pr-unsubscr...@jena.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@jena.apache.org For additional commands, e-mail: pr-h...@jena.apache.org
