Aklakan commented on PR #3753: URL: https://github.com/apache/jena/pull/3753#issuecomment-3900332769
Overall it looks good. I occasionally got failing query cancel tests on a 14 core machine - before and with your PR. The patch adds one more QueryIterFailed/try-catch block and synchronizes a `closeIterator` method. With those changes I didn't see any further build/test failures. [gh3751-tdb-reorder.patch](https://github.com/user-attachments/files/25309153/gh3751-tdb-reorder.patch) to be applied from project root with `patch -p0 < gh3751-tdb-reorder.patch` The synchronized method should solve this race-condition between regular close and concurrent cancel. ``` [INFO] Running org.apache.jena.geosparql.geo.topological.CancelQueryTest java.util.concurrent.ExecutionException: java.lang.IndexOutOfBoundsException: Index 0 out of bounds for length 0 at java.base/java.util.concurrent.FutureTask.report(FutureTask.java:124) at java.base/java.util.concurrent.FutureTask.get(FutureTask.java:193) at org.apache.jena.geosparql.geo.topological.CancelQueryTest.runAsyncAbort(CancelQueryTest.java:155) at org.apache.jena.geosparql.geo.topological.CancelQueryTest.test_cancel_spatial_property_function1(CancelQueryTest.java:124) at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104) at java.base/java.lang.reflect.Method.invoke(Method.java:565) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56) at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:299) at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:293) at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:328) at java.base/java.lang.Thread.run(Thread.java:1474) Caused by: java.lang.IndexOutOfBoundsException: Index 0 out of bounds for length 0 at java.base/jdk.internal.util.Preconditions.outOfBounds(Preconditions.java:100) at java.base/jdk.internal.util.Preconditions.outOfBoundsCheckIndex(Preconditions.java:106) at java.base/jdk.internal.util.Preconditions.checkIndex(Preconditions.java:302) at java.base/java.util.Objects.checkIndex(Objects.java:365) at java.base/java.util.ArrayList.get(ArrayList.java:428) at org.apache.jena.util.iterator.NiceIterator$1.close(NiceIterator.java:152) at org.apache.jena.util.iterator.NiceIterator.close(NiceIterator.java:203) at org.apache.jena.util.iterator.Map1Iterator.close(Map1Iterator.java:64) at org.apache.jena.util.iterator.NiceIterator.close(NiceIterator.java:203) at org.apache.jena.util.iterator.Map1Iterator.close(Map1Iterator.java:64) at org.apache.jena.atlas.iterator.Iter.close(Iter.java:719) at org.apache.jena.sparql.engine.iterator.QueryIterPlainWrapper.closeIterator(QueryIterPlainWrapper.java:72) at org.apache.jena.sparql.engine.iterator.QueryIteratorBase.close(QueryIteratorBase.java:194) at org.apache.jena.sparql.engine.iterator.QueryIter.close(QueryIter.java:88) at org.apache.jena.sparql.engine.iterator.QueryIteratorBase.performClose(QueryIteratorBase.java:224) at org.apache.jena.sparql.engine.iterator.QueryIter1.closeIterator(QueryIter1.java:46) at org.apache.jena.sparql.engine.iterator.QueryIteratorBase.close(QueryIteratorBase.java:194) at org.apache.jena.sparql.engine.iterator.QueryIter.close(QueryIter.java:88) at org.apache.jena.sparql.engine.iterator.QueryIterRepeatApply.closeSubIterator(QueryIterRepeatApply.java:110) at org.apache.jena.sparql.engine.iterator.QueryIter1.closeIterator(QueryIter1.java:45) at org.apache.jena.sparql.engine.iterator.QueryIteratorBase.close(QueryIteratorBase.java:194) at org.apache.jena.sparql.engine.iterator.QueryIter.close(QueryIter.java:88) at org.apache.jena.sparql.engine.iterator.QueryIteratorBase.nextBinding(QueryIteratorBase.java:156) at org.apache.jena.sparql.engine.iterator.QueryIterProcedure.moveToNextBinding(QueryIterProcedure.java:76) at org.apache.jena.sparql.engine.iterator.QueryIteratorBase.nextBinding(QueryIteratorBase.java:166) at org.apache.jena.sparql.engine.iterator.QueryIteratorWrapper.moveToNextBinding(QueryIteratorWrapper.java:45) at org.apache.jena.sparql.engine.iterator.QueryIteratorBase.nextBinding(QueryIteratorBase.java:166) at org.apache.jena.sparql.engine.iterator.QueryIteratorWrapper.moveToNextBinding(QueryIteratorWrapper.java:45) at org.apache.jena.sparql.engine.iterator.QueryIteratorBase.nextBinding(QueryIteratorBase.java:166) at org.apache.jena.sparql.engine.iterator.QueryIteratorBase.next(QueryIteratorBase.java:143) at org.apache.jena.sparql.engine.iterator.QueryIteratorBase.next(QueryIteratorBase.java:46) at org.apache.jena.sparql.exec.RowSetStream.next(RowSetStream.java:57) at org.apache.jena.sparql.exec.RowSetStream.next(RowSetStream.java:33) at org.apache.jena.sparql.engine.ResultSetStream.nextBinding(ResultSetStream.java:90) at org.apache.jena.sparql.engine.ResultSetStream.nextSolution(ResultSetStream.java:115) at org.apache.jena.sparql.engine.ResultSetStream.next(ResultSetStream.java:123) at org.apache.jena.geosparql.geo.topological.CancelQueryTest.doCount(CancelQueryTest.java:133) at org.apache.jena.geosparql.geo.topological.CancelQueryTest.lambda$runAsyncAbort$0(CancelQueryTest.java:146) at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:328) at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1090) at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:614) ... 1 more [ERROR] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1.288 s <<< FAILURE! -- in org.apache.jena.geosparql.geo.topological.CancelQueryTest [ERROR] org.apache.jena.geosparql.geo.topological.CancelQueryTest.test_cancel_spatial_property_function1[number of geometries: 31,623] -- Time elapsed: 1.286 s <<< FAILURE! java.lang.AssertionError: expected:<class org.apache.jena.query.QueryCancelledException> but was:<class java.lang.IndexOutOfBoundsException> at org.junit.Assert.fail(Assert.java:89) at org.junit.Assert.failNotEquals(Assert.java:835) at org.junit.Assert.assertEquals(Assert.java:120) at org.junit.Assert.assertEquals(Assert.java:146) at org.apache.jena.geosparql.geo.topological.CancelQueryTest.runAsyncAbort(CancelQueryTest.java:161) at org.apache.jena.geosparql.geo.topological.CancelQueryTest.test_cancel_spatial_property_function1(CancelQueryTest.java:124) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
