Aklakan commented on PR #3753: URL: https://github.com/apache/jena/pull/3753#issuecomment-3904760077
My work notebook has: 12th Gen Intel(R) Core(TM) i9-12900HK Hm, indeed a concurrent close during `hasNextBinding / moveToNextBinding` is not ideal - but any exception thrown there should still lead to a clean close in the end - the exception cause might be misleading (e.g. already closed). I am worried that removing the forced close from `QueryIterPlainWrapper.closeIterator` might cause blocking. Normally, the QueryIterPlainWrapper would honor abort on the next call to `hasNextBinding / moveToNextBinding` - so the close might not be needed. The thing is, that `QueryIterPlainWrapper` wraps a plain iterator. Plain iterators may have `close()` but they don't have abort. One solution could be to add abort to atlas iterators: Move the abort logic from `QueryIteratorBase` to an atlas `AbortableIterator<T>` and have both atlas Iterators and QueryIterator inherit the same mechanism. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
