potiuk commented on PR #3966: URL: https://github.com/apache/jena/pull/3966#issuecomment-4676239639
Thanks @afs and @rvesse — a genuinely expert pass; between you you've answered most of §14 and surfaced two real gaps I'd missed. Where each lands: **New surfaces (@afs):** - **`jena-text` (Lucene, incl. in Fuseki)** — agreed, adding it to the component table as an in-scope engine component (L39). - **JSON-LD remote-file reading** (L27) — good catch; a real SSRF-adjacent surface (noting the in-flight W3C JSON-LD WG mitigation work). It joins `SERVICE` as an outbound-fetch lever in §6/§9 — disable/allow-list at the operator boundary. - **SPARQL family + validation/extension modules** (`jena-shacl`/`shex`/`geosparql`/`serviceenhancer`) and the store breakdown (`jena-db` framework, TDB1/TDB2/text) — folding your L32/L47/L49 in. **§14 answers (@rvesse), confirmed into the model:** - **`SERVICE`** = the SSRF lever — disable if unused / egress allow-list when enabled (§9/§10). - **ARQ JavaScript + custom Java functions** = opt-in, requires explicit Fuseki *and* JVM/classpath config → operator-trusted code execution, not a default surface (§5a/§10). - **Admin `/$/*`** = localhost-only by default; exposing it needs auth config (§4). - **DoS/resource** (query timeout, request-size limits via reverse proxy) = operator config; known RDF/SPARQL-community traits, not Jena bugs (§9/§11a). In-process use = the app's responsibility to validate input + parameterised queries (§10). - **TDB FAQs** (the recurring memory-leak threads) — a perfect §11a "known non-findings" seed; I'll cite them. On mechanics: I know you're holding your suggestion-commits so the PMC reviews the as-is draft — I won't push over them. Whenever you land your edits I'll fold @afs's new surfaces + the §14 confirmations on top so they don't collide; or I'm happy to roll it all into one consolidated revision for you to review. Your call. Thank you both — this is the input that makes the model triage-ready. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
