kinow commented on code in PR #4052:
URL: https://github.com/apache/jena/pull/4052#discussion_r3610141342
##########
jena-fuseki2/jena-fuseki-ui/src/views/dataset/Upload.vue:
##########
@@ -368,7 +371,11 @@ export default {
},
upload: {
handler () {
- this.validateFiles()
+ if (this.upload.files && this.upload.files.length > 0) {
+ this.fileUploadClasses = ['btn', 'btn-success', 'is-valid']
+ } else if (!this.fileUploadClasses.includes('is-invalid')) {
+ this.fileUploadClasses = ['btn', 'btn-success']
+ }
Review Comment:
Couldn't the above be added to the `validateFiles`? Now there's some
duplication/overlapping code, but I think the function could do if () else if
() else (the else if would have this new check for `is-invalid`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
