Hello, I have found some places in the collective where the code has some CR ending line (^M) and some tabulation. It has broken some products lately with indentation problems, (LinguaPlone, PloneBoard IIRC)
I would like to suggest adding a pre-commit hook in the collective (and in other repositories if it's not the case) to prevent from this. I don't think it is overkill to do this, especially in such repositories where a lot of people work. As a result, this would pop an error on commits when such characters are found. I have set such a hook in our repository, it's quite simple (see http://tarekziade.wordpress.com/2006/11/01/protecting-a-python-svn-code-base-with-the-pre-commit-hook with a small variation: it also display line numbers now) ++ Tarek -- View this message in context: http://www.nabble.com/Proposal%3A-adding-a-pre-commit-hook-in-the-collective-tp14577671s20094p14577671.html Sent from the Product Developers mailing list archive at Nabble.com. _______________________________________________ Product-Developers mailing list [email protected] http://lists.plone.org/mailman/listinfo/product-developers
