wichert wrote: > >> Maybe we should run a cleaner on the whole repo itself before hooking >> it. > > -10 > > I want to be very careful here: the collective contains lots of code > from lots of people and we do not own any of it. People should be free > to have code that uses tabs for indenting or any other convention that > they prefer. Doing large changes over the entire collective will have > very little benefit and may result in a lot of conflicts when people > try to update or commit their code. > > What we should be looking for is things that we know will always break > code. A pdb.set_trace() in code is an example, as is mixing different > eol-styles. >
Ok, sounds good. We could come up with various, configurable protection levels I guess, Like Alexander said, a stronger QA check on Plone core might be interesting wichert wrote: > > I intend to use your script as inspiration for improvements of the > existing pre-commit hook we already have. > I can put my package in the collective to gather those scripts if you're willing to share them too -> I think it would be a nice package to publish for people that want to protect their repository the same way. -- View this message in context: http://www.nabble.com/Proposal%3A-adding-a-pre-commit-hook-in-the-collective-tp14577671s20094p14594969.html Sent from the Product Developers mailing list archive at Nabble.com. _______________________________________________ Product-Developers mailing list [email protected] http://lists.plone.org/mailman/listinfo/product-developers
