Details would be nice in the commit message. "corrected" doesn't really explain the issue. But I guess that's just a suggestion for later.
Looking at the implementation itself, I don't remember what situation the 'NB. The number of points in the last interval is undercounted by 1' is good for. I could look it up, but I think comments should focus on purpose rather than just mention implementation details. Is this something you feel comfortable elaborating on? Thanks, -- Raul On Wed, May 19, 2021 at 4:04 AM Ric Sherlock <[email protected]> wrote: > > I've made some changes to stats/base in this Pull request > https://github.com/jsoftware/stats_base/pull/5 > Any suggestions/objections? > > Changes are basically: > * the current version of histogram is replaced with histogram2 (also > called histogramL) > * histogram1 is added as histogramR > * added Idotr > * added binnedData > > > On Wed, Apr 14, 2021 at 3:59 PM Gilles Kirouac <[email protected]> wrote: > > > > > Will histogram1 and histogram2 be added to stats/base? > > > > > > ~ Gilles > > ---------------------------------------------------------------------- > > For information about J forums see http://www.jsoftware.com/forums.htm > > > ---------------------------------------------------------------------- > For information about J forums see http://www.jsoftware.com/forums.htm ---------------------------------------------------------------------- For information about J forums see http://www.jsoftware.com/forums.htm
