Perfect upgrade!
histogram does not lead to lost data any more.
_5 0 5 histogram _2 _7 0 3 9
1 1 2 1
Thanks, Ric, for all future users.
~ Gilles
Le 2021-05-19 à 08:01, Raul Miller a écrit :
Yes.. I should have been reading the updated code, rather than the commits.
It's been too long since I did anything serious with github.
Sorry about the noise.
Thanks,
-- Raul On Wed, May 19, 2021 at 6:12 AM Ric Sherlock <[email protected]>
wrote:
Hi Raul,
The pull request is named "Update histogram to correctly count items in
last bin" and links to Issue #4 (
https://github.com/jsoftware/stats_base/issues/4) that was filed in the
repository called "histogram doesn't count all the data". That mentions the
problems to be addressed and also links to the forum thread where the issue
was raised and discussed. Not sure that we need to revisit all that again
in the commit message?
I think the comment you're referring to is one I added to the original
version of histogram which I renamed to histogram0 in the first commit. My
thinking was that if for whatever reason we decided we needed to keep that
implementation, then we should at least note that it undercounts the final
bin. You'll notice in the 2nd commit of the pull request I remove that verb
along with the comment.
Hope that makes sense?
----------------------------------------------------------------------
For information about J forums see http://www.jsoftware.com/forums.htm
