#542: WebSearch - all-containing perform_request_search() makes it very hard to
re-use search engine
------------------------+----------------------
  Reporter:  rchyla     |      Owner:  valkyrie
      Type:  defect     |     Status:  assigned
  Priority:  major      |  Milestone:
 Component:  WebSearch  |    Version:
Resolution:             |   Keywords:  refactor
------------------------+----------------------

Comment (by jblayloc):

 Hi Roman,  Could you push the branch with this refactoring someplace?
 Github or whatever would be fine.  I seem to be having trouble getting
 your patches to apply cleanly, and a branch would really be much simpler.

 {{{
 $ patch -p0 search_engine.py search_engine.3.patch
 patching file search_engine.py
 Hunk #1 succeeded at 929 (offset 37 lines).
 Hunk #3 succeeded at 1063 (offset 37 lines).
 Hunk #4 FAILED at 4194.
 Hunk #5 succeeded at 4436 with fuzz 2 (offset 108 lines).
 Hunk #6 succeeded at 4394 (offset 37 lines).
 Hunk #7 succeeded at 4488 (offset 108 lines).
 Hunk #8 succeeded at 4437 (offset 37 lines).
 Hunk #9 FAILED at 4473.
 Hunk #10 FAILED at 4955.
 3 out of 10 hunks FAILED -- saving rejects to file search_engine.py.rej
 }}}

-- 
Ticket URL: <http://invenio-software.org/ticket/542#comment:11>
Invenio <http://invenio-software.org>

Reply via email to