#131: Correct parentheses support in in search parsing
------------------------+---------------------------------------------------
  Reporter:  jblayloc   |       Owner:  jblayloc                       
      Type:  defect     |      Status:  assigned                       
  Priority:  critical   |   Milestone:                                 
 Component:  WebSearch  |     Version:                                 
Resolution:             |    Keywords:  INSPIRE Invenio Syntax News Oct
------------------------+---------------------------------------------------

Comment (by jblayloc):

 ''1) Cosmetic comment: if we take Peter Norvig's code and chances are it''

 Ok, I've changed the logic.py to be logicutils.py.  I started to go back
 and try minimizing the number of changes to the library for easier
 merging, and I simultaneously remembered that about a third of those
 changes were necessary to eliminate code dependencies on other AIMA
 modules, and realized that AIMA hasn't had a significant update in a year
 or more.  So taking over maintenance is probably fine.

 ''2a) try to query for:

 (ellis -muon (|kaon))

 you will get mismatched parens warning;''

 This is probably related to the problem outlined in #269.  I'll look into
 this.

 ''2b) try the following query:

 (ellis )

 which gets parsed as:

 basic search units are: [['+', '(ellis', '', 'w'], ['+', ')', '', 'w']]

 which is not correct;''

 This is definitely #269.  Note that master is broken as well.

 ''2c) try queries like:

 U(1)
 U(1) -SL(2,Z)
 (U(1) -SL(2,Z))

 The last one fails. (Actually, you can just run
 python ./websearch_regression_tests.py --yes-i-know, since we have
 a test case for this `apparently nested' parens case that is not
 really a nested parens case.)''

 The unit test for U(1) fails against Atlantis in master as well.  But I'll
 do my best to get it working in my branch.

-- 
Ticket URL: <http://invenio-software.org/ticket/131#comment:12>
Invenio <http://invenio-software.org>

Reply via email to