#131: Correct parentheses support in in search parsing
------------------------+---------------------------------------------------
Reporter: jblayloc | Owner: jblayloc
Type: defect | Status: assigned
Priority: critical | Milestone:
Component: WebSearch | Version:
Resolution: | Keywords: INSPIRE Invenio Syntax News Oct
------------------------+---------------------------------------------------
Comment (by tbrooks):
So I just went through and confirmed that 2 a,b,c are all behaving the
same on a machine running Joe's branch, inspirebeta, and invenio-
demo.cern.ch i.e. it looks like they are all three separate from the
original fix that this commit is meant to resolve.
While it would be nice to clean these things up now, (i.e Joe is thinking
about it, and they may indeed have been caused by other recent commits on
search behavior from Rado, me, or Joe, or somewhere else altogether) I
don't think any of the 3 are nearly as important on an October timescale
as the main commit for nested parens, which fixes a number of user-facing
/user-reported issues.
I'd propose to get that moving along, and create new tickets for these
additional fixes.
When creating new tickets it is also worth understanding why the
regression tests for the (U(1) OR SL(2,Z)) expects a different result with
or without parens. Indeed invenio-master does behave differently in the
two cases (albeit not in the manner expected by the test case) but I can't
see why the test should not expect the same results there (cf.
{{{
def test_special_terms_u1_and_sl_or(self):
"""websearch - query for special terms, U(1) OR SL(2,Z)"""
self.assertEqual([],
test_web_page_content(CFG_SITE_URL +
'/search?of=id&p=U%281%29+OR+SL%282%2CZ%29',
expected_text="[57, 79, 80,
88]"))
def test_special_terms_u1_and_sl_or_parens(self):
"""websearch - query for special terms, (U(1) OR SL(2,Z))"""
self.assertEqual([],
test_web_page_content(CFG_SITE_URL +
'/search?of=id&p=%28U%281%29+OR+SL%282%2CZ%29%29',
expected_text="[57, 79,
88]"))
}}}
--
Ticket URL: <http://invenio-software.org/ticket/131#comment:13>
Invenio <http://invenio-software.org>
