On Fri, 14 Feb 2020 at 12:50, Bartłomiej Płotka <[email protected]> wrote:
> Hi, > > > Even with all that the release shepard would still need to go through > all the commits and double check that nothing was missed, plus fixing poor > wording. I don't think saving 2-3 minutes off a release is worth all these > downsides. > > *It is 2h do it properly for mere mortals Brian (: *Seriously, have been > there. > I'm not sure what you're doing, but what I do is get github to give me a list of all commits, and then open a new tab for each of them with middle click - ignoring the ones I know aren't relevant (e.g. doc changes). I then go through the tabs, copying&pasting the one line description (which will include the issue number) for the ones that are relevant, and editing where the description isn't great. Finally I'll do a pass over everything to ensure that related changes are grouped together etc. Even with all these changes, the only thing you'd save is the copying&pasting bit as the release shepard still needs to do all of the rest which is why I'm saying 2-3 minutes. I'm not in favour of making code reviews harder for the sake of saving a lesser amount of time during releases. Brian > I think we already had some discussion with Goutham about it. In Thanos, > we require CHANGELOG entry. Sure - we will miss some, but the end job for > release Shephard is then 80% quicker and easier. I don't think that's a big > problem for the contributor. Why do we need to suffer if in most cases > contributor is even happy to contribute CHANGELOG entry? If the contributor > says "no, I don't know how or I am lazy", sure, we will do it for them, but > only then. > > I would vote for a PR template that encourages changelog entry and asking > contributors for optional changelog entry addition. > > There was a solid discussion with Goutham on IRC about the separate issues > with this approach: Merge conflicts in CHANGELOG.md. I think we should > treat this as a separate discussion - we might have just a tool e.g google > doc to track this. > > Kind Regards, > Bartek > > > On Fri, 14 Feb 2020 at 07:22, Brian Brazil < > [email protected]> wrote: > >> On Fri, 14 Feb 2020 at 07:10, Frederic Branczyk <[email protected]> >> wrote: >> >>> I recall Simon having a tool that would largely generate the changelog >>> automatically, that worked pretty well last time I was release shepherd. >>> Otherwise I'm also happy to discuss a process like in Kubernetes where the >>> changelog item is written into the PR. On Thanos we have in the PR template >>> that people have ensured that the changelog item was added respective to >>> the change. Seems like there are options, >>> >> >> >> >>> I personally would favor something that would be done at contribution >>> time, so not all the responsibility falls on the release shepherd as it >>> does today, and more generally it seems like the person contributing the >>> change probably is also a good candidate to describe it in the changelog. >>> >> >> This is additional friction to contributions, we already have enough fun >> getting the DCO signed. It's also an additional burden on every single PR, >> we need to individually figure out if it's worth mentioned in the changelog >> (many PRs aren't) and then get it in the right category, with good wording, >> and handling the regular conflicts as everyone would be touching the same >> lines in the same file. >> >> Even with all that the release shepard would still need to go through all >> the commits and double check that nothing was missed, plus fixing poor >> wording. I don't think saving 2-3 minutes off a release is worth all these >> downsides. >> >> Brian >> >> >>> >>> On Fri, 14 Feb 2020 at 08:05, Callum Styan <[email protected]> >>> wrote: >>> >>>> Hi all, >>>> >>>> I'd like to start a discussion around changing how we manage the >>>> prometheus/prometheus changelog, specifically the fact that the changelog >>>> is generated manually by the release shepherd as part of the release >>>> process. >>>> >>>> We can discuss options for what the new process would look like, such >>>> as requiring PR's to include changelog entries before merging or the next >>>> release shepherd periodically updating the changelog prior to the release, >>>> in more detail later. However I'd first like to get a sense of whether >>>> anyone else feels strongly about either changing or not changing this part >>>> of the release process. >>>> >>>> Thanks, >>>> Callum. >>>> >>>> -- >>>> You received this message because you are subscribed to the Google >>>> Groups "Prometheus Developers" group. >>>> To unsubscribe from this group and stop receiving emails from it, send >>>> an email to [email protected]. >>>> To view this discussion on the web visit >>>> https://groups.google.com/d/msgid/prometheus-developers/CAN2d5OTjOrCfpRF_NXGcQB5nOz%3DVPgnz3LdEk15ucV4PFz%2B4BQ%40mail.gmail.com >>>> <https://groups.google.com/d/msgid/prometheus-developers/CAN2d5OTjOrCfpRF_NXGcQB5nOz%3DVPgnz3LdEk15ucV4PFz%2B4BQ%40mail.gmail.com?utm_medium=email&utm_source=footer> >>>> . >>>> >>> -- >>> You received this message because you are subscribed to the Google >>> Groups "Prometheus Developers" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to [email protected]. >>> To view this discussion on the web visit >>> https://groups.google.com/d/msgid/prometheus-developers/CAOs1UmyOfHbC75bdk55frFQt-KYgD6cg7vh%2BCPSmVmMnSV3sng%40mail.gmail.com >>> <https://groups.google.com/d/msgid/prometheus-developers/CAOs1UmyOfHbC75bdk55frFQt-KYgD6cg7vh%2BCPSmVmMnSV3sng%40mail.gmail.com?utm_medium=email&utm_source=footer> >>> . >>> >> >> >> -- >> Brian Brazil >> www.robustperception.io >> >> -- >> You received this message because you are subscribed to the Google Groups >> "Prometheus Developers" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/prometheus-developers/CAHJKeLrFL_kN28EiagWYFbKMr5XWC%2Bk7h8n9D8VijvmOnX_5Tw%40mail.gmail.com >> <https://groups.google.com/d/msgid/prometheus-developers/CAHJKeLrFL_kN28EiagWYFbKMr5XWC%2Bk7h8n9D8VijvmOnX_5Tw%40mail.gmail.com?utm_medium=email&utm_source=footer> >> . >> > -- Brian Brazil www.robustperception.io -- You received this message because you are subscribed to the Google Groups "Prometheus Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/prometheus-developers/CAHJKeLpPcXPsXtXgWOPdm5Ur5BL6Yz4%2Bo12T1B9y23jx52uOLQ%40mail.gmail.com.
