On 24 May 20:32, Brian Brazil wrote: > On Sun, 24 May 2020 at 20:17, Julien Pivotto <[email protected]> > wrote: > > > Dear developers, > > > > It has crossed my mind that we are planning to move the node_exporter > > https package to github.com/prometheus/common/ in the near future. > > > > I think that for the benefit of the whole community, it might be better > > to move it to our "public code" repository, > > github.com/prometheus/client_golang. > > > > We know that e.g. cortex is already interesting to reuse this, and I > > think that basically any Golang-based exporter would benefit from this. > > A lot of them will probably depend on that code in the future. > > > > If we do so, it would still be possible to mark it as EXPERIMENTAL at > > the beginning, but we would recognize that it can be used by the whole > > community. > > > > Note: I am also volunteering to be the 'assigned maintainer' of that > > code, whether it comes in the client_golang or in common. > > > > WDYT? > > > > There's one technical problem here, client_golang currently supports back > to Go 1.9. The https code as written requires Go 1.14 for simplicity, which > we can get away with in common as we control all the binaries including it > and common as internal code. Bjeorn as maintainer of client_golang would > have to chime in on this aspect.
We could make that two different modules. Would require tags that start with 'https': https/v0.1.0 + different go.mod. Since it is completely different from the rest, that would be an option too. Would also allow us to propagate security issues without updating the full client_golang. -- Julien Pivotto @roidelapluie -- You received this message because you are subscribed to the Google Groups "Prometheus Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/prometheus-developers/20200524193629.GA119053%40oxygen.
