I was thinking about building an "exporter kit" repo that would include some helpful functions to reduce the amount of boilerplate needed to write exporters.
Perhaps we could star this project, have the https code moved there? github.com/prometheus/exporter/https On Wed, May 27, 2020 at 12:00 AM Julien Pivotto <[email protected]> wrote: > On 26 May 21:15, Bjoern Rabenstein wrote: > > On 24.05.20 21:17, Julien Pivotto wrote: > > > > > > I think that for the benefit of the whole community, it might be better > > > to move it to our "public code" repository, > github.com/prometheus/client_golang. > > > > I don't think that github.com/prometheus/client_golang is our "public > > code" repository. It's the Go instrumentation client, which happens to > > share its repository with the experimental and not properly maintained > > HTTP API client. The latter is essentially an accident, a result of a > > habit of certain core contributors back then to "just do" things > > without discussing them in depth with their peers. Go Modules weren't > > a thing back then, otherwise I would have resisted more strongly. > > > > With Go Modules in the game, we should either avoid putting multiple > > more or less independent libraries into the same repo, or we need to > > embrace multi-module repos after all. I haven't developed an educated > > opinion about the latter yet. I just noticed a number of fairly strong > > statements that multi-module repos are supposed to be very painful. > > > > Having said all that, github.com/prometheus/common is of course just > > as problematic as a location. It contains many independent libraries > > in the same repo. It would essentially be impossible to have > > meaningful post-1.0 semver in that repo without turning it into a > > multi-module repo. Plus, the common repo is (by now) explicitly marked > > as an internal one. > > > > The most straight forward solution right now is to create a new repo > > "github.com/prometheus/tls" or similar. (And I would then advocate to > > move the HTTP API client out of client_golang into its own repo, > > should we ever see that it is steering towards a v1.0 release.) > > I would be in favor of creating a new repository. As I said, it is > important to be able to release that quickly and independently, and also > trying to follow go semver "for real" in this repo. > > > If people feel strongly about the proliferation of repos in the > > Prometheus GH org, I'm willing to educate myself about multi-module > > repositories so that I can say if I will support or resist a move to a > > multi-module client_golang repo (if that's possible in a non-breaking > > fashion at all - if not, we should probably plan to make the common > > repo multi-module). > > This is code that is going to be used and share across many > repositories, I think if we are willing to put it in a separate repo we > should do it. > > > -- > > Björn Rabenstein > > [PGP-ID] 0x851C3DA17D748D03 > > [email] [email protected] > > > > -- > > You received this message because you are subscribed to the Google > Groups "Prometheus Developers" group. > > To unsubscribe from this group and stop receiving emails from it, send > an email to [email protected]. > > To view this discussion on the web visit > https://groups.google.com/d/msgid/prometheus-developers/20200526191532.GQ2326%40jahnn > . > > -- > Julien Pivotto > @roidelapluie > > -- > You received this message because you are subscribed to the Google Groups > "Prometheus Developers" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/prometheus-developers/20200526192156.GA1130273%40oxygen > . > -- You received this message because you are subscribed to the Google Groups "Prometheus Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/prometheus-developers/CABbyFmoh49%2BrvMpFaM8fwTEpQS%2BFyHHtuNhS_C%2B%3DKOwe7SkDUw%40mail.gmail.com.
