On the tsdb part, yes I'm inline with you Julien in a sense where it's complicated to test it.
But I think here you could start with a light environment and then improve it later to check much more things. Besides I would be a bit surprised than you cannot install some exporter and a Consul server for the discovery. @Sven: I suppose that's possible doesn't it ? Of course you won't cover every possibility every test for the tsdb and of course it won't cover the benchmark test, but that's a start. You are the expert here so you will tell me if I'm completely wrong. But I guess you have a sort of checklist when you are fast testing the tsdb from PR. And I suppose for most of these test it doesn't require a complicated dev environment. And instead of pulling the PR, compiling the binary, potentially starting the different exporter, server needed for the discovery and so on, well you have it online. So potentially you will gain time. Le lun. 27 juil. 2020 à 09:07, Sven Efftinge <s...@gitpod.io> a écrit : > Hey all, > > Just chiming in to let you know that I'm happy to answer any questions you > have. > FWIW Gitpod requires just the config file and the app (for CI), so it > doesn't have a lot of footprint for those who absolutely don't want to > use it. > > Sven > > On Mon, 27 Jul 2020 at 08:33, Augustin Husson <husson.augus...@gmail.com> > wrote: > >> Hello, >> >> So far what I understood is that you have two things: >> 1. The possibility of coding online using a tablet >> 2. Having an online environment where your PR has been built. And like >> that you can play with the prometheus instance and test it smoothly. >> >> ( I know I reduced a lot the features provided ) >> >> I think the 2nd point is maybe the more interesting from a developer >> point of view. Since you will be able to see from the PR if the >> expectations brought are achieved. Of course it's easier to check it when >> it concerned the UI. But it could be used to check more tricky things such >> as the tsdb. >> >> >> IMHO this is an old dream I never see working properly. Meaning having a >> dedicated environment created for each PR. And it seems they did it. It >> would be super cool to have it. >> >> If I was able to have it the private company I would be so happy since it >> would make it super easier when reviewing the PR. ( Because you won't have >> to pull the PR + build it + launch it + test it. Which takes time, and if >> you have a huge amount of PR, then you just skip these parts usually, >> trusting that is working like it was previously designed). >> >> >> Le dim. 26 juil. 2020 à 18:19, Julien Pivotto <roidelapl...@prometheus.io> >> a écrit : >> >>> Hello, >>> >>> While getting new contributors is fundamental for any open source >>> projects, I would be on the side to explore other possibilities than this >>> one. Let me explain my concerns. >>> >>> First of all, that is an extra tool. I am not a fan on adding extra >>> tools on top of GitHub, like gerrithub or other review platforms. >>> Especially tools that would not be used by us as a team. >>> >>> When we redirect our users to a third party platform, we are 'endorsing' >>> then in some way. I have not investigated the specifics of the proposed >>> platforms, but we would have to review the tos of that platform and look if >>> that is in line with our expectations. >>> >>> We have got in the past first time contributors starting features, >>> implementations, and then vanish before the code is in a mergeable state. >>> We should find a compromise so that such a platform to embark more people >>> does not lead us in that direction more often. >>> >>> I also note that the scope is unclear. Is that for the react app? For >>> TSDB? It would be strange to have a solution that would only work for one >>> of them, e.g. react, because otherwise if someone comes with a solution for >>> TSDB, we would end up with two solutions. >>> >>> I do note that the open source version is limited to 50h/month; and that >>> the application itself has < 1000 users according to GitHub. >>> >>> Le dim. 26 juil. 2020 à 14:42, Julius Volz <julius.v...@gmail.com> a >>> écrit : >>> >>>> +CC Sven from Gitpod >>>> >>>> On Sun, Jul 26, 2020 at 2:40 PM Julius Volz <julius.v...@gmail.com> >>>> wrote: >>>> >>>>> Hi, >>>>> >>>>> I got to know the people from Gitpod.io (https://www.gitpod.io/), and >>>>> when I learned about their capability to not only use Gitpod as a regular >>>>> online web-based dev environment, but to create ad-hoc environments based >>>>> off PR branches as CI checks, I thought it would be a really neat thing to >>>>> have that for Prometheus (it's free for OSS). It would also be generally >>>>> great to give people a web-based container that has Prometheus pre-built >>>>> and the dev environment ready and setup for working on the code. A >>>>> proposed >>>>> PR for the latter is here (AFAIK this doesn't do the CI integration yet, >>>>> but that would be great too, then you can explore with the binary + code >>>>> at >>>>> a PR branch online, without checking it out locally): >>>>> https://github.com/prometheus/prometheus/pull/7673 >>>>> >>>>> What do people think? >>>>> >>>>> Cheers, >>>>> Julius >>>>> >>>> -- >>>> You received this message because you are subscribed to the Google >>>> Groups "Prometheus Developers" group. >>>> To unsubscribe from this group and stop receiving emails from it, send >>>> an email to prometheus-developers+unsubscr...@googlegroups.com. >>>> To view this discussion on the web visit >>>> https://groups.google.com/d/msgid/prometheus-developers/CA%2BT6YoygV%3Dz3hDjb06DeK8E9ikT7RRe5tswnvvw_d%2Bv%2BOfnh2w%40mail.gmail.com >>>> <https://groups.google.com/d/msgid/prometheus-developers/CA%2BT6YoygV%3Dz3hDjb06DeK8E9ikT7RRe5tswnvvw_d%2Bv%2BOfnh2w%40mail.gmail.com?utm_medium=email&utm_source=footer> >>>> . >>>> >>> -- >>> You received this message because you are subscribed to the Google >>> Groups "Prometheus Developers" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to prometheus-developers+unsubscr...@googlegroups.com. >>> To view this discussion on the web visit >>> https://groups.google.com/d/msgid/prometheus-developers/CAFJ6V0rLMnJqju_7fOHPACJMGwdw8m0-ePdvLsDJUHFbXQNVAg%40mail.gmail.com >>> <https://groups.google.com/d/msgid/prometheus-developers/CAFJ6V0rLMnJqju_7fOHPACJMGwdw8m0-ePdvLsDJUHFbXQNVAg%40mail.gmail.com?utm_medium=email&utm_source=footer> >>> . >>> >> -- You received this message because you are subscribed to the Google Groups "Prometheus Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to prometheus-developers+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/prometheus-developers/CAOJizGdtLnRuNAHZwUKSo7ytk%2BFsm0SZfy5XdnOQhkw8Gon_zw%40mail.gmail.com.
