Yes! I was chatting to Beorn about this the other week... Big +1 from me. Mind adding a line for /storage/remote too?
Thanks Tom On Mon, Mar 1, 2021 at 8:05 PM Julius Volz <[email protected]> wrote: > Heya all, > > Julien often helpfully pings me on PRs that touch the React UI, but it > would be much nicer if I could somehow get auto-notified by GitHub > specifically of those that touch anything under /web/ui/. Others might feel > the same about their areas of purview. > > GitHub has a CODEOWNERS file feature ( > https://docs.github.com/en/github/creating-cloning-and-archiving-repositories/about-code-owners), > which allows specifying owners for parts of a repo, which then get > auto-assigned as reviewers for PRs touching those files. > > Is anyone opposed to me experimenting with a CODEOWNERS file that only has > a rule about /web/ui for a start? So just a line like: > > # Assign any UI-related PRs to Julius. > /web/ui @juliusv > > That would give me the notifications I want, as a side effect of > auto-assigning me as a reviewer for UI PRs at the same time (which should > be fine for that subdir as well). If that works well, others can start > using the file as well. > > Regards, > Julius > > -- > You received this message because you are subscribed to the Google Groups > "Prometheus Developers" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/prometheus-developers/CA%2BT6Yozt9UCqty8cVXYsaa-KjMmqPcPi5iQwNAg9t_erByM%2B3Q%40mail.gmail.com > <https://groups.google.com/d/msgid/prometheus-developers/CA%2BT6Yozt9UCqty8cVXYsaa-KjMmqPcPi5iQwNAg9t_erByM%2B3Q%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > -- You received this message because you are subscribed to the Google Groups "Prometheus Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/prometheus-developers/CAB58Z128st_cgbn%2BKeH6-AuyZd0XZWKL2hifPPXfoG5nmG9Whw%40mail.gmail.com.
