Yeah, I was thinking the same as Julius said, but maybe it's fair to see who wants to opt-in to this and who doesn't.
FWIW I added myself as codeowner of the Kubernetes service discovery just like it's mentioned in the maintainers file. https://github.com/prometheus/prometheus/pull/8553 On Mon, 1 Mar 2021 at 21:18, Julius Volz <[email protected]> wrote: > Great - I made a PR at https://github.com/prometheus/prometheus/pull/8552. > > I added /storage/remote, but at that point maybe we want to add all the > other dirs with specific maintainers as well? > > On Mon, Mar 1, 2021 at 9:10 PM Tom Wilkie <[email protected]> wrote: > >> Yes! I was chatting to Beorn about this the other week... Big +1 from >> me. Mind adding a line for /storage/remote too? >> >> Thanks >> >> Tom >> >> On Mon, Mar 1, 2021 at 8:05 PM Julius Volz <[email protected]> wrote: >> >>> Heya all, >>> >>> Julien often helpfully pings me on PRs that touch the React UI, but it >>> would be much nicer if I could somehow get auto-notified by GitHub >>> specifically of those that touch anything under /web/ui/. Others might feel >>> the same about their areas of purview. >>> >>> GitHub has a CODEOWNERS file feature ( >>> https://docs.github.com/en/github/creating-cloning-and-archiving-repositories/about-code-owners), >>> which allows specifying owners for parts of a repo, which then get >>> auto-assigned as reviewers for PRs touching those files. >>> >>> Is anyone opposed to me experimenting with a CODEOWNERS file that only >>> has a rule about /web/ui for a start? So just a line like: >>> >>> # Assign any UI-related PRs to Julius. >>> /web/ui @juliusv >>> >>> That would give me the notifications I want, as a side effect of >>> auto-assigning me as a reviewer for UI PRs at the same time (which should >>> be fine for that subdir as well). If that works well, others can start >>> using the file as well. >>> >>> Regards, >>> Julius >>> >>> -- >>> You received this message because you are subscribed to the Google >>> Groups "Prometheus Developers" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to [email protected]. >>> To view this discussion on the web visit >>> https://groups.google.com/d/msgid/prometheus-developers/CA%2BT6Yozt9UCqty8cVXYsaa-KjMmqPcPi5iQwNAg9t_erByM%2B3Q%40mail.gmail.com >>> <https://groups.google.com/d/msgid/prometheus-developers/CA%2BT6Yozt9UCqty8cVXYsaa-KjMmqPcPi5iQwNAg9t_erByM%2B3Q%40mail.gmail.com?utm_medium=email&utm_source=footer> >>> . >>> >> -- > You received this message because you are subscribed to the Google Groups > "Prometheus Developers" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/prometheus-developers/CA%2BT6Yoz4GkHP6wJNPcW3JuAxq4%3D%3D7p4dp7cO3b853iYO43UPpw%40mail.gmail.com > <https://groups.google.com/d/msgid/prometheus-developers/CA%2BT6Yoz4GkHP6wJNPcW3JuAxq4%3D%3D7p4dp7cO3b853iYO43UPpw%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > -- You received this message because you are subscribed to the Google Groups "Prometheus Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/prometheus-developers/CAOs1UmywWsDE7tKESJ_xmNhMeQbz7MGCDnF63DaKQai_Gk_e1Q%40mail.gmail.com.
