Hi João, On Tue, 9 Apr 2019 at 15:41, João Duarte <[email protected]> wrote: > > > My very humble rookie attempt at dealing with issue 1315, after struggling > with a lot of prosody stuff this last week =D
Looks fine overall :) Anything in particular you struggled with? We're definitely interested in feedback from new contributors, so we can find out what parts we should put more time into simplifying/documenting (contribution here would be welcome too if you're up for it!). Regarding the patch, if you can fix these two issues, we can merge it: 1) the changes to the configure file should not be in the commit. If you have a recent-enough mercurial, you can do this with: # First switch to the commit you want to fix (if it isn't already your current commit): hg update 58118875 # Remove the 'configure' file from the commit hg amend --extract configure 2) There is a minor typo in the help line, 'CLose' instead of 'Close'. Again after you fix this, just run `hg amend plugins/mod_admin_telnet.lua` to update the commit with your fix. If you then export the new commit (`hg export .` will export the current commit) then we can merge it! Regards, Matthew -- You received this message because you are subscribed to the Google Groups "prosody-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at https://groups.google.com/group/prosody-dev. For more options, visit https://groups.google.com/d/optout.
