I like to have patches sent using codereview.appspot.com to make it easy for us to review. Petar ([email protected]) is in charge of Python protobufs so you should send the review to him (and CC me).
On Sat, Jan 17, 2009 at 8:09 AM, Will P <[email protected]> wrote: > > Hi all, > I have a speed enhancement patch for wire_format.py (python), but I'm > not sure how to submit the enhancement.... It's not a defect, so it > shouldn't go in as an "Issue" right? > > It's a very small change (17 lines) which provides a 2x-3x speedup for > the function. I also have comparison test code that shows the new > version is equivalent to the old version of this function. > > I can post the diff and testing function comparison code... > > But I would appreciate knowing the best process to follow for > submitting a patch (especially speed enhancements, not just bugfixes). > > Thanks! > > > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Protocol Buffers" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/protobuf?hl=en -~----------~----~----~----~------~----~------~--~---
