Comment #13 on issue 83 by halostatue: protobuf does not compile cleanly in 64-bit mode in Visual Studio 2008
http://code.google.com/p/protobuf/issues/detail?id=83

Yeah, it's a little ugly, but it's consistent with what I've seen in gtest. The problem with the truncating_cast as you've specified is that both warning 4244 and 4267 are reported; there are probably others you'd have to
worry about.

I think that explicit casts may be the way to fix this, but I'm not sure offhand (we'd have to test it in our build,
which I don't see happening for a few days).

This matters very much to us because we have "treat warnings as errors" and these are in headers that, if I
recall correctly, we can't avoid using in our code.

A possible different alternative is to change the code generator so that the generated .cc files include these headers with the appropriate pragma warning(disable: 4244 4267) guard (again; I don't recall if it's
"warning(disable: 4244 4267)" or "warning(disable: 4244, 4267)").

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups "Protocol 
Buffers" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/protobuf?hl=en.

Reply via email to