Right, depth-first post-order *is* a (reverse) topological sort, which is what we're looking for here.
On Thu, Jul 22, 2010 at 8:42 AM, Jason Hsueh <[email protected]> wrote: > The "outbound edge" in the topological sort is from dependency to > dependent. This provides the guarantee that a file dependency will appear > before its dependent in the FileDescriptorSet. This is conceptually > equivalent to starting at some FileDescriptor and traversing its > dependencies depth-first. > > On Wed, Jul 21, 2010 at 11:38 PM, Nader Salehi <[email protected]>wrote: > >> If any dependency needs to be build beforehand, then how is >> topological ordering is supported? >> >> >> On 7/21/2010 17:39 Jason Hsueh writes: >> > Ordering is important because any dependencies need to be built before >> they >> > are used - if you give an arbitrary order there may be errors >> complaining >> > about undefined symbols or imports not being found. A depth first >> ordering >> > will work, and that's exactly what protoc does when producing >> > FileDescriptorSet now. The change you were alluding to was released in >> > 2.3.0. >> > >> > On Wed, Jul 21, 2010 at 4:42 PM, Nader Salehi <[email protected]> >> wrote: >> > >> > > I was wondering if there was a "correct" way of building a set >> > > containing multiple files with dependency(ies). Looking at the old >> > > archives, I know Kenton has mentioned the next set of protoc (when?) >> > > will output FileDescriptorSet in topological order, but would any >> > > other order work equally the same? Would a Depth First approach of >> > > adding files and their dependencies do? >> > > >> > > Cheers, >> > > Nader >> > > >> > > -- >> > > You received this message because you are subscribed to the Google >> Groups >> > > "Protocol Buffers" group. >> > > To post to this group, send email to [email protected]. >> > > To unsubscribe from this group, send email to >> > > [email protected]<protobuf%[email protected]> >> <protobuf%[email protected]<protobuf%[email protected]> >> > >> > > . >> > > For more options, visit this group at >> > > http://groups.google.com/group/protobuf?hl=en. >> > > >> > > >> > > -- > You received this message because you are subscribed to the Google Groups > "Protocol Buffers" group. > To post to this group, send email to [email protected]. > To unsubscribe from this group, send email to > [email protected]<protobuf%[email protected]> > . > For more options, visit this group at > http://groups.google.com/group/protobuf?hl=en. > -- You received this message because you are subscribed to the Google Groups "Protocol Buffers" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/protobuf?hl=en.
